Conversation
| // Signature checks skipped for emulator; no need to fetch public keys. | ||
|
|
||
| try { | ||
| verifyJwtSignature( |
There was a problem hiding this comment.
I would recommend maybe keeping the verifyJwtSignature function call, and modifying the function to only catch JWTExpiredException, since the handling of JWTExpiredException is the same in both verifiers.
| @internal | ||
| factory TokenProvider.fromMap(Map<dynamic, dynamic> map) { | ||
| return TokenProvider( | ||
| identities: map['identities']! as Map<String, Object?>, |
There was a problem hiding this comment.
Since behavior changed here, would you mind writing a test?
|
I made the changes do we need more tests for the emulator related changes? |
| 'phone_number': 'mock-phone-number', | ||
| 'picture': 'mock-picture', | ||
| 'sub': 'mock-sub', | ||
| 'uid': 'mock-sub', |
There was a problem hiding this comment.
The doc says that uid isn't actually present in the token, and this field is just a convenience that takes its value from sub. How about removing this line then?
|
I believe this should also fix #56, would you mind updating the description? |
|
Done |
|
Awesome, thanks! |
|
@rrousselGit can you please review and release this fix? Thanks |
|
@rrousselGit or anyone else who can review and approve this pull request? I'm eagerly awaiting this fix to be released. Thanks. |
Co-authored-by: Matteo Battaglio <matteo.battaglio@gmail.com>
…into pr/jtdLab/58
|
Had to move to a separate PR because of secrets. It took me way too long to realise 🤷 But LGTM, thanks! |
6 participants
Related Issues
fixes #57
fixes #56
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).I have updated the
CHANGELOG.mdof the relevant packages.Changelog files must be edited under the form:
If this contains new features or behavior changes,
I have updated the documentation to match those changes.